Reducing query counts on processing and removing 1+N queries in Admin View #118
Conversation
…efore command finishes does not fail and reduce queries on sending by 2.
| ) | ||
|
|
||
| # Check if we're inside an atomic block, if not, commit immediately to store the message | ||
| if not transaction.get_connection().in_atomic_block: |
There was a problem hiding this comment.
what is the reason for this change?
There was a problem hiding this comment.
I had this in my branch and was a left over from here #45. Issue is, the message is not stored before sending, and if partner sends an MDN back before the message is commited to DB, then the MDN fails and triggers a "no message found" error. This should prevent this.
There was a problem hiding this comment.
The reason for this is, because tests fun in atomic transaction and therefore this will fail. The behavior of the django test is different than when running the command "normally". transaction.commit() would fail if running inside an atomic transaction.
There was a problem hiding this comment.
We should not be writing code to handle for tests, this needs to be handled differently. Can be picked later
There was a problem hiding this comment.
We don't know how anyone would be using this command - someone might wrap this command in an atomic transaction which would then fail this too probably. So I don't see this as "for tests"...
Originally I was going to use a config flag if we are in test mode or not, but then we even have more "only test specific" code.
Let me know if you want me to simple remove this from this PR, then I will and you can decide at a later point how you want this.
| if not transaction.get_connection().in_atomic_block: | ||
| transaction.commit() | ||
|
|
||
| message.organization = org |
There was a problem hiding this comment.
add a comment on why you are doing this
| """Send the message to the partner""" | ||
|
|
||
| if self.organization_id and self.partner_id: | ||
| self.organization = self.organization or Organization.objects.get( |
There was a problem hiding this comment.
I have noted that under certain circumstances (i.e. update_or_create) will not keep the related object inside the model. So, in case that this is happening, then we pull it once more, but we are not pulling it, when it exists already, thus not executing another query.
pyas2/tests/test_basic.py
Outdated
| query for query in queries if "SAVEPOINT" not in query["sql"] | ||
| ] | ||
|
|
||
| # number of queries should be 9 |
|
|
2 participants
#116