Skip to content

fix: use blocking sleep instead of asyncio in tests #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use blocking sleep instead of asyncio in tests #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/ably/rest/restchannelpublish_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import mock
import msgpack
import pytest
import asyncio
import time

from ably import api_version
from ably import AblyException, IncompatibleClientIdException
Expand Down Expand Up @@ -404,7 +404,7 @@ async def test_interoperability(self):
# 1)
await channel.publish(data=expected_value)
# temporary added delay, we need to investigate why messages don't appear immediately
await asyncio.sleep(1)
time.sleep(1)
async with httpx.AsyncClient(http2=True) as client:
r = await client.get(url, auth=auth)
item = r.json()[0]
Expand All @@ -417,7 +417,7 @@ async def test_interoperability(self):
# 2)
await channel.publish(messages=[Message(data=msg_data, encoding=encoding)])
# temporary added delay, we need to investigate why messages don't appear immediately
await asyncio.sleep(1)
time.sleep(1)
history = await channel.history()
message = history.items[0]
assert message.data == expected_value
Expand Down