-
Notifications
You must be signed in to change notification settings - Fork 43
Chat/add images and examples for UI component docs #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@jamiehenson I had to make some changes to the renderer to allow for the larger UI components, hope that's okay! If there is a better way to do it, happy to make a change! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stuff you've added for the new "single large" layout looks good on the whole, I just have a few pointers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a FE perspective 👍 I would look into that min-height
-> height
change before you go tho
4a6307a
to
534cb23
Compare
534cb23
to
bc16fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ( somehow I cant preview it, but excited to see the changes )
bc16fe8
to
7274ce7
Compare
7274ce7
to
462be23
Compare
src/images/examples/chat-ui-app.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get the Design team to make more tile friendly images for the 3 examples? On the examples page, these look like there's too much going on / the images are too big for the size they're being shown at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll ping design, see if I can get some input here :)
137a682
to
e6e0ec3
Compare
… React - Update the ExamplesRenderer.tsx to allow for large-scale examples, such as the App and Chat window. - Updated the index and types files to include the examples.
…xamplesRenderer - Added multiple screenshots to documentation for better visualization of Chat UI components. - Adjusted layout logic in `ExamplesRenderer.tsx` to better handle smartphones.
e6e0ec3
to
f62236b
Compare
Description
Added examples for App, Chat window and Sidebar components.
Updated docs to correct the style imports.
Added UI screens for the chat components section.
Checklist