Add type hints to package #157
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
reviewed
Jun 25, 2025
There was a problem hiding this comment.
@jaimergp I you are willing to do all the typing changes and updates, this is mucho welcomed! and will be merged.
|
@jaimergp do you want to get commit rights on the repo? |
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
* Raise NotImplementedError instead of returning it Signed-off-by: Jono Yang <[email protected]> * Update CHANGELOG.rst Signed-off-by: Jono Yang <[email protected]> --------- Signed-off-by: Jono Yang <[email protected]> Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
|
I manually added type hints for all modules. This is a first pass, and |
I'm flattered, but I can't "commit" (heh!) to this responsibility right now, thanks! |
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Signed-off-by: jaimergp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from package-url/packageurl-python#186 (comment)
Files
src/univers/__init__.pysrc/univers/arch.pysrc/univers/conan/__init__.pysrc/univers/conan/errors.pysrc/univers/conan/version_range.pysrc/univers/conan/version.pysrc/univers/debian.pysrc/univers/gem.pysrc/univers/gentoo.pysrc/univers/maven.pysrc/univers/nuget.pysrc/univers/rpm.pysrc/univers/univers_semver.pysrc/univers/utils.pysrc/univers/version_constraint.pysrc/univers/version_range.pysrc/univers/versions.py