Return errors as json objects instead of strings #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a mapping in
config/locales/en.yml
to convert error messages to keys, which we then look up in web's translations. I realised that by using@object.errors.errors
we can just directly return the attributes of each error.A response with errors would then become:
Options can be filled with more detail if needed. (For example, if we would have length validations: `{"attribute" => "title", "type" => "too_long", "options" => { "count" => 50 }
@chvp What do you think? Wanted to check this principle first, before I update the controllers, and js-client and web.