Skip to content

[issue_tracker] Introduce Rejected status & Medications category #9391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[issue_tracker] Introduce Rejected status & Medications category #9391

wants to merge 3 commits into from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Oct 7, 2024

Brief summary of changes

  • Add Rejected status to issue tracker. Only someone with Can re-assign issues, mark issues as closed, comment on all, edit issues. permission can change the status to this.

Testing instructions (if applicable)

  1. When creating an issue, make sure that the rejected status option only appears if you have the permission: 'Can re-assign issues, mark issues as closed, comment on all, edit issues.'
  2. Repeat with editing an issue

CCNA OVERRIDE PR

@cmadjar
Copy link
Collaborator

cmadjar commented Oct 8, 2024

@skarya22 tests are failing. could you fix them?

kongtiaowang
kongtiaowang reviewed Oct 8, 2024
View reviewed changes
@maximemulder maximemulder added Project: CCNA Issue or PR related to the CCNA project and removed Priority: Projects labels Dec 2, 2024
@skarya22 skarya22 requested a review from GeorgeMurad December 3, 2024 20:12
GeorgeMurad
GeorgeMurad approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

driusan
driusan requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "rejected" status makes sense but the "Medications" category seems project specific and doesn't require any code changes. It's just a config from a config table that doesn't require any overrides. can you remove it from this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang left review comments

@driusan driusan driusan requested changes

@GeorgeMurad GeorgeMurad GeorgeMurad approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@GeorgeMurad GeorgeMurad

Labels
Project: CCNA Issue or PR related to the CCNA project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skarya22 @cmadjar @driusan @kongtiaowang @GeorgeMurad @maximemulder