Skip to content

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented May 13, 2025

Brief summary of changes

  • Adds a study progression tab that showcases some nice stats such as the ones below. Used the getWidgets function in the module so that only users with access to the module can see it
  • Links to the modules, and only shows up if you have permission to it
  • Includes changes in [dashboard] Optimize statistics queries #9793
image

Testing instructions (if applicable)

  1. As admin, try to press the links to the modules. Confirm that when possible, it uses the Project filter.
  2. Login as a user without access to a module, confirm it does not take you to a page you do not have access to

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: imaging_browser PR or issue related to imaging_browser module labels May 13, 2025
@skarya22 skarya22 changed the title [dashboard] CBIGR Overrides [dashboard] CBIGR Dashboard Overrides May 13, 2025
@skarya22
Copy link
Contributor Author

@skarya22 split into two PRs, with the optimizations for 27 release

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label May 13, 2025
@github-actions github-actions bot added the Module: dashboard PR or issue related to dashboard module label May 13, 2025
@skarya22 skarya22 changed the title [dashboard] CBIGR Dashboard Overrides [dashboard] New Study Progression Panel May 14, 2025
@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label May 14, 2025
@regisoc regisoc added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jul 7, 2025
@regisoc
Copy link
Contributor

regisoc commented Jul 7, 2025

@skarya22 after rebase, please assign @adamdaudrich

@skarya22 skarya22 assigned adamdaudrich and unassigned skarya22 Jul 8, 2025
@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 30, 2025
@skarya22 skarya22 requested a review from adamdaudrich July 30, 2025 19:21
@skarya22 skarya22 assigned adamdaudrich and unassigned skarya22 Jul 30, 2025
@adamdaudrich
Copy link
Collaborator

lGtm

Copy link
Collaborator

@adamdaudrich adamdaudrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGtm

@skarya22 skarya22 requested a review from driusan August 5, 2025 17:57
@skarya22 skarya22 added the Passed manual tests PR has been successfully tested by at least one peer label Aug 7, 2025
@skarya22 skarya22 assigned driusan and unassigned adamdaudrich Aug 18, 2025
@skarya22 skarya22 requested a review from driusan September 3, 2025 17:50
@driusan
Copy link
Collaborator

driusan commented Sep 3, 2025

@skarya22 seems to be failing static tests because of phpcs

@driusan
Copy link
Collaborator

driusan commented Sep 4, 2025

I checked out this branch and there's a useless scrollbar on the side of the widget for me
studyprogression (using vivaldi, which is chromium-based).

This says it's adding a new study progression panel, but the existing graphs seem to have disappeared and I find it looks weird to not have any graphs on the dashboard. What happened to the existing ones?

@skarya22
Copy link
Contributor Author

skarya22 commented Sep 4, 2025

@driusan Resolved the scrollbar issue. The charts are all still accessible through the "Views" dropdown, only change is that the default is this summary panel instead of the scans one. There are new charts being added in #9937 that adds a chart to the first panel, which will make the dashboard have a chart again

Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works now.

@driusan driusan merged commit 9c2712e into aces:main Sep 4, 2025
20 checks passed
SKADE2303 pushed a commit to SKADE2303/Loris that referenced this pull request Sep 5, 2025
- Adds a study progression tab that showcases some nice stats such as
the ones below. Used the getWidgets function in the module so that only
users with access to the module can see it
- Links to the modules, and only shows up if you have permission to it
- Includes changes in aces#9793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: dashboard PR or issue related to dashboard module Module: imaging_browser PR or issue related to imaging_browser module Module: statistics PR or issue related to statistics module Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants