Skip to content

[dataquery] Fixed Import csv for Empty csv and submitting without uploading #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 27.0-release
Choose a base branch
from

Conversation

SKADE2303
Copy link
Collaborator

Brief summary of changes

  1. An error is thrown for empty CSVs for both choices in the 'CSV containing list of' dropdown (Candidates and Sessions)
  2. If an incorrectly formatted csv is uploaded, it is cleared from selection and not allowed to submit.
  3. If user clicks on 'Submit' without uploading a csv, an error is thrown.

Testing instructions

  1. Go to DQT (Beta)
  2. Click on "Continue to Define Field"
  3. Select any number of fields
  4. Under Define Filters, click on "Import from CSV"
  5. In the ‘CSV containing a list of’ dropdown:
    - First select Candidates
    - Upload an empty CSV file.
    -> An error message would be thrown and no CSV would be loaded
  6. Repeat the same steps but this time:
    -Select Sessions
    -Upload an empty CSV file.
    -> An error message would be thrown and no CSV would be loaded
  7. After step 4, Click on Submit without uploading any CSV. An error would be thrown notifying the user that no CSV is uploaded.

Link(s) to related issue(s)

@github-actions github-actions bot added the Module: dataquery PR or issue related to (new) dataquery module label Jun 19, 2025
@SKADE2303 SKADE2303 changed the title Fixed Import csv for Empty csv and submitting without uploading [dataquery] Fixed Import csv for Empty csv and submitting without uploading Jun 19, 2025
@racostas racostas self-requested a review June 20, 2025 15:28
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and looks good to me.

@racostas racostas added the Event: GSOC PR or issue accepted for Google Summer of Code label Jun 20, 2025
@driusan driusan changed the base branch from main to 27.0-release June 20, 2025 15:37
@driusan
Copy link
Collaborator

driusan commented Jun 20, 2025

@SKADE2303 can you rebase this onto the 27.0-release branch?

@SKADE2303 SKADE2303 force-pushed the 2025_06_20_dataquery_fix_definefilters.importcsvmodal branch from 12d8aeb to 2e72ddb Compare June 26, 2025 17:50
@racostas
Copy link
Contributor

Hi @driusan, I confirm @SKADE2303 properly rebased this PR. Cloud you please take a final look and merged into 27 or into a bug_fix if the case ?

Thanks !

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Jun 26, 2025
@racostas racostas requested a review from driusan June 26, 2025 18:42
@christinerogers
Copy link
Contributor

@driusan could this be included in the next 27 bug fix release?

It's ready for your re-review (since June)

@christinerogers christinerogers added 27.0.0 - Bugs Bugs Found in LORIS 27 testing Category: Bug PR or issue that aims to report or fix a bug labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Category: Bug PR or issue that aims to report or fix a bug Event: GSOC PR or issue accepted for Google Summer of Code Module: dataquery PR or issue related to (new) dataquery module Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dataquery] Inconsistent and Incomplete Validation in CSV Import Tool for Filters
4 participants