Skip to content

[publication] Fix collaborator behaviour #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Jul 10, 2025

Brief summary of changes

  • Publication collaborator behaviour was a bit confusing and not future proof. Issues such as:
    • Two publications could not have a collaborator with the same name and different emails
    • Same issue with Lead Investigator and a collaborator in another publication
  • Resolved by separating the publication_collaborator table to have one entry per collaborator per publication. There is no reason for two publications to point to the same collaborator since they are editable in each publication.

Testing instructions (if applicable)

  1. Create a publication with lead investigator x, and collaborator y
  2. Create another publication with lead investigator y and collaborator x
  3. Create another publication with lead investigator x but a different email
  4. create another publication with collaborator y but with a different email
  5. create another publication with some other name, but collaborator y's email

Link(s) to related issue(s)

This is an Override from CCNA

@skarya22 skarya22 added the Project: CCNA Issue or PR related to the CCNA project label Jul 10, 2025
@github-actions github-actions bot added Language: SQL PR or issue that update SQL code Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: publication PR or issue related to the publication module labels Jul 10, 2025
@skarya22 skarya22 force-pushed the 2025_07_10_Fix_Publication_Collaborator_Bhehaviour branch from f67635e to 8acaf8d Compare July 17, 2025 14:05
@skarya22
Copy link
Contributor Author

@kongtiaowang could you take a look at this? I can't figure out why the test is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: publication PR or issue related to the publication module Project: CCNA Issue or PR related to the CCNA project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[publication] Can not enter email for collaborator
1 participant