-
Notifications
You must be signed in to change notification settings - Fork 183
[imaging_browser] Translate imaging browser #9989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
msgid "Pending New" | ||
msgstr "" | ||
|
||
msgid "Entity Type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mentioned on a different module's PR that this should be in the loris namespace
msgid "Links" | ||
msgstr "" | ||
|
||
msgid "SessionID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this turning up that's user facing? (cc @cmadjar)
msgid "all types" | ||
msgstr "" | ||
|
||
msgid "NEW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"NEW" is in the loris namespace.
msgstr "" | ||
|
||
msgid "Pass" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgid "Header Info" | ||
msgstr "" | ||
|
||
msgid "Selected" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make sure "Selected" (uppercase) is next to "selected" (lowercase) in the .pot
file to make it easier to translate?
I just tried testing this by adding Japanese translations and the "viewSession" page isn't getting translated for me. It looks like InfoPanel.jsx is marked up, the strings are in the .pot/.po files, and I added the resource bundle in imagingBrowserIndex.js. Is there anything else I need to change to add a new language for this module? |
This PR is responsible for translating the module imaging_browser to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)