Skip to content

Conversation

SKADE2303
Copy link
Collaborator

@SKADE2303 SKADE2303 commented Aug 29, 2025

This PR is responsible for translating the module imaging_browser to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to imaging_browser tab to see translated web page.

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: imaging_browser PR or issue related to imaging_browser module labels Aug 29, 2025
@SKADE2303 SKADE2303 added Multilingual Any tasks related to making LORIS multilingual Event: GSOC PR or issue accepted for Google Summer of Code labels Aug 29, 2025
Saket Hatwar added 2 commits August 29, 2025 16:27
msgid "Pending New"
msgstr ""

msgid "Entity Type"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mentioned on a different module's PR that this should be in the loris namespace

msgid "Links"
msgstr ""

msgid "SessionID"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this turning up that's user facing? (cc @cmadjar)

msgid "all types"
msgstr ""

msgid "NEW"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"NEW" is in the loris namespace.

msgstr ""

msgid "Pass"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmadjar @ridz1208 Are pass/fail/selected common LORIS terms across modules or imaging_browser specific?

msgid "Header Info"
msgstr ""

msgid "Selected"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make sure "Selected" (uppercase) is next to "selected" (lowercase) in the .pot file to make it easier to translate?

@driusan
Copy link
Collaborator

driusan commented Sep 2, 2025

I just tried testing this by adding Japanese translations and the "viewSession" page isn't getting translated for me.

It looks like InfoPanel.jsx is marked up, the strings are in the .pot/.po files, and I added the resource bundle in imagingBrowserIndex.js.

Is there anything else I need to change to add a new language for this module?

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: imaging_browser PR or issue related to imaging_browser module Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants