cmake: Use GNUInstallDirs to install data directories #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I add a
Signed-off-by: you
Tothe patch?
…On Wed, Apr 12, 2023 at 4:15 PM Timo Gurr ***@***.***> wrote:
Solves issues with cross environments where prefix is set to e.g.
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and the arch
independent files would end of under the prefix as well instead of
/usr/share.
Note: variables offered by CMake GNUInstallDirs could probably used for
the various other stuff as well like for getting rid of the __lib hack by
using CMAKE_INSTALL_LIBDIR but I just wanted to solve an actual issue I
ran across with this PR.
------------------------------
You can view, comment on, or merge this pull request online at:
#41
Commit Summary
- 01213b6
<01213b6>
cmake: Use GNUInstallDirs to install data directories
File Changes
(1 file <https://github.com/acmel/dwarves/pull/41/files>)
- *M* CMakeLists.txt
<https://github.com/acmel/dwarves/pull/41/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a>
(8)
Patch Links:
- https://github.com/acmel/dwarves/pull/41.patch
- https://github.com/acmel/dwarves/pull/41.diff
—
Reply to this email directly, view it on GitHub
<#41>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIAU5X5HXIFTBQMFHK5NR3XA35MFANCNFSM6AAAAAAW4DADKY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@acmel Sure yes, whatever you want. Also please tell if I should rather do it myself if that's easier for you. |
|
Em Wed, Apr 12, 2023 at 01:06:27PM -0700, Timo Gurr escreveu:
> Can I add a Signed-off-by: you Tothe patch?
@acmel Sure yes, whatever you want. Also please tell if I should rather do it myself if that's easier for you.
I can do it, thanks!
- Arnaldo
… --
Reply to this email directly or view it on GitHub:
#41 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
@acmel I've updated the PR to add the requested Signed-off-by. |
|
Gentle ping. |
Signed-off-by: Timo Gurr <[email protected]>
|
Updated to not duplicate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues with cross environments where prefix is set to e.g.
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnuand the arch independent files would end up under the prefix as well instead of/usr/share.Note: variables offered by CMake
GNUInstallDirscould probably be used for the various other stuff as well like for getting rid of the__libhack by usingCMAKE_INSTALL_LIBDIRbut I just wanted to solve an actual issue I ran across with this PR.