chore: Update sha.js version #1098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusmanii
requested review from
mrice32,
nicholaspai,
pxrl and
bmzig
as code owners
Signed-off-by: Faisal Usmani <[email protected]>
fusmanii
force-pushed
the
faisal/update-sha-js
branch
from
bd89e30 to
a82c50c
Compare
nicholaspai
approved these changes
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
| "**/eth-crypto/secp256k1": "5.0.1" | ||
| "**/eth-crypto/secp256k1": "5.0.1", | ||
| "**/create-hash/sha.js": "2.4.12", | ||
| "sha.js": "2.4.12" |
There was a problem hiding this comment.
Do we know where this outdated version comes from? If it's in the uma repo we should probably go upstream and fix it there so we don't need to override the resolution.
There was a problem hiding this comment.
It looks like its coming from ethereum-cryptography which ethereumjs-util depends on
There was a problem hiding this comment.
we are at latest version of ethereumjs-util already, so I think we need the resolution until they patch on their end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulnerability in sha.js <= 2.4.11 GHSA-95m3-7q98-8xr5