Skip to content

Feat/twitter share #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Feat/twitter share #1642

wants to merge 24 commits into from

Conversation

gsteenkamp89
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 commented Jun 26, 2025 •
edited
Loading

closes ACX-3968

Outstanding Items

  • Final tweet copy
  • Style redirect link

@gsteenkamp89
add canvas dep
577c14b 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
draw base layer image, serve with page & necessary tags
1262125 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add unstyled component. build URL
34297ad 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
style banner
47f4f6c 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@vercel Vercel
Copy link

vercel bot commented Jun 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 10:50am
sepolia-frontend-v3 🛑 Canceled (Inspect) Jul 18, 2025 10:50am

@linear Linear
Copy link

linear bot commented Jun 26, 2025

ACX-3968 Add Twitter Share on confirmation screen

@gsteenkamp89
fixup
dad022d 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fix
0612b9b 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixes
1e2bab7 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add transitive system deps for canvas
2c8fb3e 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add canvas as a dev dependency
6d31ea4 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
test new dimensions
d2b7406 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
square image
e9cda1a 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
serve better html
47550f7 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixup
7451509 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89 gsteenkamp89 marked this pull request as ready for review June 30, 2025 15:56
james-a-morris
james-a-morris previously approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending ryan's QA

@james-a-morris
Copy link
Member

we should remove the -2.png images (zora + OP)

@gsteenkamp89
serve content based on user agent
9b248a3 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
remove some duplicate icons
d3a101c 
Signed-off-by: Gerhard Steenkamp <[email protected]>
james-a-morris
james-a-morris reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component looks good - one question about the API

.github/actions/setup/action.yaml
Comment on lines +9 to +11
- name: Install canvas dependencies
run: sudo apt-get update && sudo apt-get install -y libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
shell: bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be an issue on vercel?

gsteenkamp89 and others added 2 commits July 3, 2025 17:45
@gsteenkamp89
use even 20px padding
a5cf7e2 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89 @james-a-morris
refactor
211a146 
Co-authored-by: James Morris, MS <[email protected]>
@gsteenkamp89
update copy
a2a5d4e 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
handle 0 seconds bridge
f5859cc 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixup
9d59695 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
update UI copy
52b1b5d 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add utm params to redirect
4b3f186 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
Merge branch 'master' into feat/twitter-share
d816bee 
Signed-off-by: Gerhard Steenkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris left review comments

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@melisaguevara melisaguevara Awaiting requested review from melisaguevara melisaguevara is a code owner

@amateima amateima Awaiting requested review from amateima amateima is a code owner

@ashwinrava ashwinrava Awaiting requested review from ashwinrava ashwinrava is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @james-a-morris