Skip to content

Fix: remove duplication from JSON schemas (fixes #297) #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Fix: remove duplication from JSON schemas (fixes #297) #515

merged 1 commit into from
Oct 21, 2025
+0 −9

Conversation

henrietta-k
Copy link
Contributor

@henrietta-k henrietta-k commented Apr 9, 2024 •
edited by oliverfoster
Loading

Fixes #297

Fix

Deleted properties in JSON schemas that are duplicated due to inheritance.

Update

Only one file was updated, which was component.schema.json. The property that was deleted was "_isA11yCompletionDescriptionEnabled".
component.schema.json makes a $ref: content on line 7, and the "_isA11yCompletionDescriptionEnabled" property has already been defined in content. The other JSON schemas do not seem to contain duplication.

Reference:

  • adapt-contrib-core/schema/content.schema.json

    Lines 108 to 115 in 2c6bcdb

    "_isA11yCompletionDescriptionEnabled": {
    "type": "boolean",
    "title": "Enable accessibility completion description",
    "description": "Controls whether a hidden label is appended to the element title that describes the completion state of the element.",
    "default": true,
    "_adapt": {
    "isSetting": true
    }

@henrietta-k henrietta-k changed the base branch from issue/297 to master April 9, 2024 19:17
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 0028ba3 into adaptlearning:master Oct 21, 2025
github-actions bot pushed a commit that referenced this pull request Oct 21, 2025
@semantic-release-bot
Chore(release): 6.71.2
a675d1a 
## [6.71.2](v6.71.1...v6.71.2) (2025-10-21)

### Fix

* remove duplication from JSON schemas (fixes #297) (#515) ([0028ba3](0028ba3)), closes [#297](#297) [#515](#515)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.71.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove duplication from JSON schemas

5 participants

@henrietta-k @oliverfoster @cahirodoherty-learningpool @ethan-lp @lemmyadams