New: Added popup:closing event + wait queue, allowed a11y.setPopupClose for notify (fixes #676)

[oliverfoster]

fixes #676

Allowed a11y.setPopupCloseTo to work with the notify. Added the popup:closing event, followed immediately by an await wait.queue() to allow other plugins to calculate and assign an element to a11y.setPopupCloseTo($element).

This works principally because the notify does not need to retain the document.activeElement when opening, as the popup API already performs this function at the following lines:

adapt-contrib-core/js/a11y/popup.js

Line 78 in e7fe240

this._addPopupLayer($popupElement);

adapt-contrib-core/js/a11y/popup.js

Line 93 in e7fe240

this._focusStack.push($(document.activeElement));

adapt-contrib-core/js/a11y/popup.js

Line 153 in e7fe240

const $previousFocusElement = this._removeLastPopupLayer();

adapt-contrib-core/js/a11y/popup.js

Line 176 in e7fe240

return this._focusStack.pop();

adapt-contrib-core/js/a11y/popup.js

Line 158 in e7fe240

this.a11y.focusFirst($($focusElement), { preventScroll: true });

Fix

• Removed code from notify to return to the previous active element and rely on the popup API to handle it

New

• Added popup:closing event with an await wait.queue such that other plugins can listen to the event and wait.begin(), a11y.setPopupCloseTo($element) and wait.end()

[cahirodoherty-learningpool]

👀

[joe-allen-89]

Currently throwing an error, missing import for wait

[oliverfoster]

thanks @joe-allen-89