Skip to content

Conversation

rococodogs
Copy link

Uses < instead of <= in the for loop within Entry::applyAttributes
to prevent an Undefined Offset notice from being thrown.

Uses `<` instead of `<=` in the `for` loop within `Entry::applyAttributes`
to prevent an Undefined Offset notice from being thrown.
@davidsteinsland
Copy link

👍

2 similar comments
@iberflow
Copy link

👍

@henriquebremenkanp
Copy link

👍

@stevebauman
Copy link

Just a heads up, this is already fixed in the main source where this master was pulled from (https://github.com/Adldap2/Adldap2).

@iberflow
Copy link

So what is the difference between adldap2 vs adldap packages? Why is it named like that? why not just create a separate branch?

@stevebauman
Copy link

Because the original author wasn't available to maintain or accept pull requests (as you can see by the massive amount of forks). I've been given push rights to this repository, but I won't maintain this without administrator rights. I can't create branches with push rights either.

@iberflow
Copy link

Ok thanks:)
Though there seem to be no docs on that repo. Is the API consistent with this one?

@iberflow
Copy link

My bad, it just wasn't in the wiki :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants