FORMS-18644: Desktop, RWD Tablet, RWD Mobile - Controls have same name but different actions @sunnym @vavarshn #1571
Conversation
…e but different actions @sunnym @vavarshn
| <template data-sly-template.questionMark="${@ componentId, longDescription, bemBlock, componentTitle}"> | ||
| <sly data-sly-set.namedTitle="${componentTitle} help text" /> | ||
| <sly data-sly-set.fullTitle="${componentTitle ? namedTitle : 'Help text'}" /> | ||
| <button class="${bemBlock}__questionmark" data-sly-test="${longDescription}" title="${fullTitle}"> |
There was a problem hiding this comment.
This will impact backward compatiblity, it would need to be addressed
There was a problem hiding this comment.
The only backwd compatibility case I could think of is this component being used without giving it he "componentTitle" param (as it was before).
I made a test using it in the "checkboxgroup" component as
<div data-sly-call="${questionMark.questionMark @componentId=checkboxgroup.id, longDescription=checkboxgroup.description, bemBlock='cmp-adaptiveform-checkboxgroup', componentTitle=checkboxgroup.label.value}" data-sly-unwrap></div>
And the text returns to "Help text" as it was initially
If there are any other compatibility cases please let me know.
|
Checked, answer added. |
| <button class="${bemBlock}__questionmark" data-sly-test="${longDescription}" title="Help text"> | ||
| <template data-sly-template.questionMark="${@ componentId, longDescription, bemBlock, componentTitle}"> | ||
| <sly data-sly-set.namedTitle="${componentTitle} help text" /> | ||
| <sly data-sly-set.fullTitle="${componentTitle ? namedTitle : 'Help text'}" /> |
There was a problem hiding this comment.
Since we are fixing this can we add localization fix as well, use following instead:
${'Help text' @ i18n}
There was a problem hiding this comment.
Added localization.
|
Please resolve conflicts here |
Description
Related Issue
https://jira.corp.adobe.com/browse/FORMS-18644
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: