@fix: file attachment delete correct file when duplicate names of files #1687

anshikag-adobe · 2025-08-07T05:49:48Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2025-08-07T06:22:49Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-07T09:16:33Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-07T09:17:48Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

anshikag-adobe · 2025-08-07T09:47:49Z

JIRA: https://jira.corp.adobe.com/browse/FORMS-21306

adobe-bot · 2025-08-07T10:18:54Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-08T04:10:03Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-08T04:10:30Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

ui.frontend/src/view/FormFileInputWidgetBase.js

adobe-bot · 2025-08-11T07:47:41Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-11T07:48:45Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

* new utility function for test added to delete a file indiviually

adobe-bot · 2025-08-11T10:00:30Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-11T10:02:28Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

codecov · 2025-08-11T10:39:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

adobe-bot · 2025-08-11T11:02:44Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-11T11:04:04Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-11T11:04:08Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-11T11:04:18Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

* override handleClick method to adapt to v3 onwards structure of fileinput * cypress tests

adobe-bot · 2025-08-11T15:22:31Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-11T15:23:03Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-11T15:56:52Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-08-12T05:19:46Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

ui.tests/test-module/specs/fileinput/fileinput.runtime.cy.js

adobe-bot · 2025-08-12T06:38:58Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-08-12T06:41:00Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

anshikag-adobe added 2 commits August 7, 2025 09:46

@fix: file attachment delete correct file when duplicate names of files

2c5938d

fix fileinput test

9d2d0a3

github-actions bot force-pushed the fileinput_deleteIcon branch from 4a6a1ff to 9d2d0a3 Compare August 7, 2025 09:46

fix fileinput testcase

c128c40

iamsudhanshu reviewed Aug 8, 2025

View reviewed changes

ui.frontend/src/view/FormFileInputWidgetBase.js Outdated Show resolved Hide resolved

@fix handleClick method fixed in derived class of fileinput

5848277

anshikag-adobe added 2 commits August 11, 2025 14:56

fileinput runtime error fix

9c82349

* new utility function for test added to delete a file indiviually

remove .only()

b5a7d48

anshikag-adobe added 2 commits August 11, 2025 15:59

update fileinput duplicate files test case

77aa04b

remove .only()

bdfc75b

anshikag-adobe added 4 commits August 11, 2025 19:59

revert the changes from main widget classes

5f782ef

revert test-case changes

c79662b

fileinput duplicate file names fix:

acb3684

* override handleClick method to adapt to v3 onwards structure of fileinput * cypress tests

cypress tests for duplicate filename delete functionality

ebfa800

sakshi-arora1 reviewed Aug 12, 2025

View reviewed changes

ui.tests/test-module/specs/fileinput/fileinput.runtime.cy.js Outdated Show resolved Hide resolved

restore fileinput runtime

e8e6570

sakshi-arora1 approved these changes Aug 12, 2025

View reviewed changes

anshikag-adobe merged commit 621002a into dev Aug 12, 2025
10 checks passed

@fix: file attachment delete correct file when duplicate names of files #1687

@fix: file attachment delete correct file when duplicate names of files #1687

Uh oh!

Conversation

anshikag-adobe commented Aug 7, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Aug 7, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 7, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 7, 2025

Accessibility Violations Found

Uh oh!

anshikag-adobe commented Aug 7, 2025

Uh oh!

adobe-bot commented Aug 7, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2025

Accessibility Violations Found

Uh oh!

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

codecov bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 12, 2025

Accessibility Violations Found

Uh oh!

Uh oh!

adobe-bot commented Aug 12, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 12, 2025

Accessibility Violations Found

codecov bot commented Aug 11, 2025 •

edited

Loading