Summary
Page descriptions are inserted into raw HTML without proper sanitization by the Citizen skin when using the old search bar.
Details
The descriptions, which are unsanitized, are inserted as raw HTML:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/d4dfc3697a82948b3b9c4d44e9a273c79bc86b87/resources/skins.citizen.search/templates/TypeaheadListItem.mustache#L18
PoC
All of the reproduction methods require the command palette to be disabled via $wgCitizenEnableCommandPalette = false;.
Additionally, the action API must be used as the Search Gateway via $wgCitizenSearchGateway = 'mwActionApi';.
TextExtracts as the description source
- Enable the TextExtracts extension
- Add
$wgCitizenSearchDescriptionSource = 'textextracts'; to your LocalSettings.php
- Create a page called
CitizenXSSTextExtracts and insert <img src="" onerror="alert('citizen search xss')"> into it
- Open the search modal and search for
CitizenXSSTextExtracts
Description2 as the description source
- Enable the Description2 extension
- Add
$wgEnableMetaDescriptionFunctions = true; to your LocalSettings.php to enable the {{#description2:}} parser function
- Add
$wgCitizenSearchDescriptionSource = 'pagedescription'; to your LocalSettings.php
- Create a page called
CitizenXSSDescription2 and insert {{#description2:<img src="" onerror="alert('citizen search xss 2')">}} into it
- Open the search modal and search for
CitizenXSSDescription2
Wikibase as the description source
Note that this method is currently untested due to issues I experienced when setting up Wikibase.
- Enable Wikibase client + repo in your wiki
- Add
$wgCitizenSearchDescriptionSource = 'wikidata'; to your LocalSettings.php
- Have an item with a description like
<img src="" onerror="alert('citizen search xss 3')">
- Open the search modal and search for the page linked to the item
ShortDescription as the description source
- Enable the ShortDescription extension
- Add
$wgCitizenSearchDescriptionSource = 'wikidata'; to your LocalSettings.php
- Create a page called
CitizenXSSDescription4 and insert {{SHORTDESC:<img src="" onerror="alert('citizen search xss 4')">}} into it
- Open the search modal and search for
CitizenXSSDescription4
Impact
On all wikis that use the aforementioned settings (command palette disabled or using an old release where the old search bar is still used; using the action API as the search gateway), anybody who can edit pages is able to insert XSS payloads into the DOM for other users who are searching for specific pages.
References
SomeMWDev Reporter
Summary
Page descriptions are inserted into raw HTML without proper sanitization by the Citizen skin when using the old search bar.
Details
The descriptions, which are unsanitized, are inserted as raw HTML:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/d4dfc3697a82948b3b9c4d44e9a273c79bc86b87/resources/skins.citizen.search/templates/TypeaheadListItem.mustache#L18
PoC
All of the reproduction methods require the command palette to be disabled via
$wgCitizenEnableCommandPalette = false;.Additionally, the action API must be used as the Search Gateway via
$wgCitizenSearchGateway = 'mwActionApi';.TextExtracts as the description source
$wgCitizenSearchDescriptionSource = 'textextracts';to your LocalSettings.phpCitizenXSSTextExtractsand insert<img src="" onerror="alert('citizen search xss')">into itCitizenXSSTextExtractsDescription2 as the description source
$wgEnableMetaDescriptionFunctions = true;to your LocalSettings.php to enable the{{#description2:}}parser function$wgCitizenSearchDescriptionSource = 'pagedescription';to your LocalSettings.phpCitizenXSSDescription2and insert{{#description2:<img src="" onerror="alert('citizen search xss 2')">}}into itCitizenXSSDescription2Wikibase as the description source
Note that this method is currently untested due to issues I experienced when setting up Wikibase.
$wgCitizenSearchDescriptionSource = 'wikidata';to your LocalSettings.php<img src="" onerror="alert('citizen search xss 3')">ShortDescription as the description source
$wgCitizenSearchDescriptionSource = 'wikidata';to your LocalSettings.phpCitizenXSSDescription4and insert{{SHORTDESC:<img src="" onerror="alert('citizen search xss 4')">}}into itCitizenXSSDescription4Impact
On all wikis that use the aforementioned settings (command palette disabled or using an old release where the old search bar is still used; using the action API as the search gateway), anybody who can edit pages is able to insert XSS payloads into the DOM for other users who are searching for specific pages.
References