Support functions to facilitate use of hasql #130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if the dependency on hasql-pool is the right thing. On the one hand we've had good success using it. On the other hand resource-pool is in much better shape now. I'm trying to figure out if there's benefit to the Hasql.Pool dependency or whether using the (newly revamped) Data.Pool would be better—or whether this library should just use hasql Connection and not be involved with connection pooling at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling errors properly when making database calls and ensuring telemetry is sent is surprisingly tricky. This introduces helper functions which facilitate doing these things systematically.