Fix race condition in gltf-model when changing src while loading #5739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
gltf-model
component would unconditionally change the model in thegltfLoad
callback. However, it's possible for thesrc
value to have changed in the meantime. In case the second model finishes loading before the first one, the component would incorrectly end up showing the first model (once it finishes loading as well).This PR adds a check to ensure that the
src
hasn't changed (similar to what is done for textures).Changes proposed:
src
changed while loading model to avoid showing the wrong modelsrc
change and removal logic.