Fixed compilation errors under ROS Humble #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added tf2_geometry_msgs dependecy to CMakeLists - changed include statement to use .hpp instead of .h
used the same default values as are already used below.
|
work well, thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of changes that enable the packages to compile under ROS Humble.
Summary of changes:
tf2_geometry_msgsas an explicit dependency inCMakeLists.txtand changed the include statement inscout_messenger.hppastf2_geometry_msgs.hhas been marked as obsolete.Node::declare_parameterby adding a default value, using the same value as was already used inScoutBaseRos::LoadParametersPlease let me know if you see any problems with any of the suggested changes.
Regards,
Valentin Veluppillai