Fix for missing glist_findrtext in new Pd versions
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, sorry - had tim's changes in my branch here already! will reset to master and force push ... EDIT: done |
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
9fbb9b3 to
3011112
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
3011112 to
d27256c
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
d27256c to
14c2892
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
14c2892 to
e4524e1
Compare
umlaeute
reviewed
Aug 18, 2025
pdlua.c
Outdated
| static t_signal_setmultiout g_signal_setmultiout; | ||
| // function pointer type for signal_setmultiout (added with Pd 0.54) | ||
| typedef void (*t_signal_setmultiout_fn)(t_signal **, int); | ||
| static t_signal_setmultiout_fn g_signal_setmultiout; |
There was a problem hiding this comment.
i find it a bit annoying that this commit mixes the renaming of the typedef of an unrelated function with the fix for the missing glist_findrtext.
There was a problem hiding this comment.
true - this is not related. i was reconsidering those type names with the additional function. but it should be fine without this change (struggling a bit with what's "good practice" there). updated the PR.
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
e4524e1 to
52d111a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the mechanism we already had in place for the multichannel handling.
uses the new
glist_getrtextif present and otherwise falls back to the previousglist_findrtexttested with Pd vanilla for official
0.55-2build and currentmasterincluding the change.