Skip to content

Adopt NI coding style (mostly) #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+1,720 −2,662
Draft

Adopt NI coding style (mostly) #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42973a6
Initial commit
alejandro5042 Sep 30, 2020
f770702
Initial commit
alejandro5042 Oct 12, 2020
1031a9a
Removing old rules
alejandro5042 Oct 12, 2020
f4f1538
Spacing fixups
alejandro5042 Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ root = true

[*]
indent_style = space
indent_size = 2
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
Expand Down
73 changes: 38 additions & 35 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,40 @@
module.exports = {
"root": true,
"env": {
"browser": true,
"es6": true,
"greasemonkey": true,
"jquery": true
},
"extends": "airbnb",
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly",
"lscache": "readonly",
"dateFns": "readonly",
"eus": "readonly",
"_": "readonly",
"hljs": "readonly",
"jsyaml": "readonly"
},
"parserOptions": {
"ecmaVersion": 2018,
"sourceType": "script"
},
"rules": {
// Tech debt. Remove or reconsider one day:
"no-unused-vars": ["error", { "args": "none" }],
"func-names": 0,
"no-use-before-define": ["error", "nofunc"],
"max-len": 0,
"no-restricted-syntax": ["error", "ForInStatement", "LabeledStatement", "WithStatement"],
"strict": 0,
"require-await": "error",
"require-yield": "error",
"linebreak-style": 0,
"arrow-parens": 0,
}
"root": true,
"env": {
"browser": true,
"es6": true,
"greasemonkey": true,
"jquery": true
},
"extends": "@ni",
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly",
"lscache": "readonly",
"dateFns": "readonly",
"eus": "readonly",
"_": "readonly",
"hljs": "readonly",
"jsyaml": "readonly"
},
"parserOptions": {
"ecmaVersion": 2018,
"sourceType": "script"
},
"rules": {
// Tech debt. Remove or reconsider one day:
"no-unused-vars": ["error", { "args": "none" }],
"func-names": "off",
"no-use-before-define": ["error", "nofunc"],
"max-len": "off",
"no-restricted-syntax": ["error", "ForInStatement", "LabeledStatement", "WithStatement"],
"strict": "off"
},
"overrides": [{
"files": [".*.js"],
"rules": {
"quote-props": "off",
"quotes": "off"
}
}],
};
Loading