Skip to content

Add an option to allow cells to be editable. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add an option to allow cells to be editable. #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880ddba
add option to allow cells to be editable
Oct 23, 2014
b6113bd
delete extra empty line at line 323
Oct 23, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jquery.dynatable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,11 @@

td += '"';
}

// allow cells to be editable
if (column.contentEditable) {
td += ' contenteditable="true"';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be contentEditable="true" for the td attribute.

Also, is setting the column header to contentEditable the best way to allow this feature on columns? Wouldn't the more common use-case be that you want only the cells to be contentEditable and not the header row?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The td is created as a string, so this is the only way to append the attribute.

That's true. One approach is to use a custom class editable/columnEditable as a check instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the attribute name, I was referring to the fact that you have contenteditable instead of contentEditable (capitalized "Editable").

Yeah, I'm thinking as a data attribute, like data-contenteditable or maybe namespaced to avoid conflicts with other libraries like data-dynatable-contenteditable on the th element in the column header cell.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was aware that I didn't use the camelCase; I should have mentioned this earlier.
Though it isn't meant to be contentEditable http://www.w3.org/TR/2008/WD-html5-20080610/editing.html#contenteditable0 ?

(I can't edit this PR that since I removed the branch a long time ago...making a new one)

}

if (column.cssClass) {
td += ' class="' + column.cssClass + '"';
Expand Down