chore: integration test for sending and waiting for asset transfers #182
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an integration test for asset transfer transactions and introduces a waitForConfirmation helper function to verify transaction confirmations. Key changes include updating transaction creation to support both payment and asset transfer types, adding a busy-loop based waitForConfirmation function, and updating a dependency version in package.json.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typescript/algod_api/tests/transactions.test.ts | Added integration tests for transaction confirmation and asset transfer support, along with a new waitForConfirmation helper. |
| packages/typescript/algod_api/package.json | Updated the dependency for @algorandfoundation/algokit-transact to a newer alpha version. |
| @@ -45,6 +51,18 @@ const createSignedTxnHttpFile = ( | |||
| return httpFile; | |||
| }; | |||
|
|
|||
| async function waitForConfirmation( | |||
There was a problem hiding this comment.
The waitForConfirmation function employs a continuous loop without any delay or timeout, which may result in high CPU usage. Consider adding an asynchronous delay (e.g., using setTimeout or a sleep function) and a timeout mechanism to break the loop if confirmation takes too long.
Copilot uses AI. Check for mistakes.
No description provided.