-
Notifications
You must be signed in to change notification settings - Fork 6
feat(utils): Adds key registration support to utils crate #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc5901
to
e68c7dd
Compare
neilcampbell
reviewed
Jul 4, 2025
/// Whether to prevent the account from ever participating in consensus again. | ||
/// - `false`: Temporary offline (can be brought back online later) | ||
/// - `true`: Permanent offline (account can never participate again) | ||
pub prevent_account_from_ever_participating_again: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
pub prevent_account_from_ever_participating_again: bool, |
The only reason this is here is because we don't have NonParticipationKeyRegistration in utils. I think we remove this one and record as a breaking change.
crates/algokit_utils/tests/transactions/composer/key_registration.rs
Outdated
Show resolved
Hide resolved
PatrickDinh
reviewed
Jul 7, 2025
e68c7dd
to
c8d9e64
Compare
313090b
to
8791328
Compare
An error occurred while trying to automatically change base from
feat/keyreg
to
main
July 8, 2025 08:16
8791328
to
3a00ec6
Compare
3a00ec6
to
44431e5
Compare
44431e5
to
3a00ec6
Compare
neilcampbell
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for online, offline, and non-participation key
registration transactions to the composer.
This enhancement allows users to manage their account's
participation in the consensus protocol. Includes relevant
parameter structs and composer methods.
Also adds integration tests to verify the behavior of the
key registration transactions.
Must be merged after #163 as this branch is based of it