Skip to content

bugfix enable wrapper openfeign client with spring-cloud-circuitbreak… #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 2023.x
Choose a base branch
from

Conversation

TianMing2018
Copy link

Describe what this PR does / why we need it

refer to issue #3979

it will fix sample sentinel-circuitbreaker-example, make it return fallback info by enable wrapper openfeign client with spring-cloud-circuitbreak…

Does this pull request fix one issue?

Fixes #3979 sentinel-feign.FeignException$InternalServerError #3979

Describe how you did it

enable spring.cloud.openfeign.circuitbreaker.enabled

Describe how to verify it

  1. git clone https://github.com/alibaba/spring-cloud-alibaba -b 2023.x
  2. open spring-cloud-alibaba-examples/sentinel-example/sentinel-circuitbreaker-example
  3. enable spring.cloud.openfeign.circuitbreaker.enabled
  4. access this endpoint http://localhost/test/default/false , it should return user fallback

Special notes for reviews

Maybe we should shade starter spring-cloud-circuitbreaker-sentinel, toggle state with spring.cloud.circuitbreaker.sentinel.enabled

By the way, I found that many projects which based on spring-boot 3.x or spring-web 6.x, required jdk17+ and Jakarta. It affect many Sentinel releated projects ,eg alibabaspring-cloud-alibabaalibaba/Sentinel and sentinel-group/sentinel-website and alibaba/Sentinel.wiki, maybe we should archived some project and write more test case (blockHandler) for other modules to improve quality.

@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentinel-feign.FeignException$InternalServerError
2 participants