[meshroom] KeyframeSelection: Fix enabled evaluation for nested attributes
#1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
requested review from
fabiencastan,
demoulinv,
servantftransperfect and
CedricThebault
…abled` Some nested attributes relied on a lambda expression that had become invalid.
cbentejac
force-pushed
the
fix/enabledKeyframeSelection
branch
from
cd4024c to
55f7c6f
Compare
fabiencastan
reviewed
Oct 2, 2025
Comment on lines
+313
to
+314
| for ext in videoExts for | ||
| input in node.inputPaths.value) |
There was a problem hiding this comment.
Suggested change
| for ext in videoExts for | |
| input in node.inputPaths.value) | |
| for ext in videoExts | |
| for input in node.inputPaths.value) |
fabiencastan
reviewed
Oct 2, 2025
Comment on lines
-218
to
+233
| description="Width, in pixels, of the frame used for the sharpness score computation after a rescale.\n" | ||
| "Aspect ratio will be preserved. No rescale will be performed if equal to 0.", | ||
| description="Width, in pixels, of the frame used for the sharpness " | ||
| "score computation after a rescale.\n" | ||
| "Aspect ratio will be preserved. No rescale will be " | ||
| "performed if equal to 0.", |
There was a problem hiding this comment.
It was not bad to have the line return when we really have it in the description.
fabiencastan
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the lambdas used to evaluate the
enabledvalue of some attributes contained inGroupAttributes. The access to such attributes is expected to be done by accessing all the parents first instead of the attribute itself directly.