Feature/cdk migration #1102
Merged
Feature/cdk migration #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set defaults using app context
…yground deploy command
…ge build workflow The test task fails with no tests for a new service, and we generate the test library with no test runner. No reason to run the test task here.
…cts instead of named stages
…objects instead of stage names
…arameter management
|
@TheOrangePuff @AdamJHall @kai-nguyen-aligent ready for review again! I made a lot of changes once again.. the most important file is I also migrated to Kai's store-parameters library for SSM parameter manage, works very nicely. |
libs/cdk-utils/src/lib/constructs/step-function-from-file.test.ts
Outdated
Show resolved
Hide resolved
|
Looking good, the injectors are a really nice addition and I'm quite fond of the documentation updates you've made 🙌 |
kai-nguyen-aligent
previously approved these changes
Aug 18, 2025
- Remove duplicate parameters section - Remove client references - Add note about parameters csv in architecture readme - Update runtime versions in tests - Add hint about updating snapshots to snapshot tests - Remove duplicate migration notes - Update description of importing services in to application - Move aws-cdk-lib to devDependencies - Remove references to LambdaFunction construct - Standardise testing of lambdas in cdk-utils - Add `yarn audit` command for a clean static analysis of everything - Removed analyse function script
|
@kai-nguyen-aligent @toddhainsworth one more round 👀 |
tvhees
dismissed
TheOrangePuff’s stale review
Devops is light on capacity. I deleted the aspect Akido was raising warnings about, and have rearchitected the app so that Stage names aren't hard coded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major overhaul of the template.
@applications/corecdk-servicegenerator