Skip to content

Re-enable A2S_RULES queries on CS:GO #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re-enable A2S_RULES queries on CS:GO #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions amstats/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,6 @@ func queryServer(addr *net.TCPAddr) (*Server, error) {
return nil, err
}

// We can't query rules for CSGO servers anymore because Valve.
csgo := (info.Ext != nil && info.Ext.AppId == valve.App_CSGO)
if csgo {
return nil, nil
}

rules, err := query.QueryRules()
if err != nil {
return nil, err
Expand Down
4 changes: 1 addition & 3 deletions blaster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,7 @@ func main() {
out.SpecTvName = info.SpecTv.Name
}

// We can't query rules for CSGO servers anymore because Valve.
csgo := (info.Ext != nil && info.Ext.AppId == valve.App_CSGO)
if !csgo && !*flag_norules {
if !*flag_norules {
rules, err := query.QueryRules()
if err != nil {
out.Rules = map[string]string{
Expand Down
2 changes: 1 addition & 1 deletion valve/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"time"
)

const kMaxPacketSize = 1400
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this isn't valid on all engines?

Copy link
Author

@Vauff Vauff Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this would only be the case for CS:GO SM servers. I assume this is still fine since it's a maximum limit?

const kMaxPacketSize = 5000

var ErrOutOfBounds = errors.New("read out of bounds")

Expand Down