Skip to content

feat(dashboard): ✨ Add new version popup #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

feat(dashboard): ✨ Add new version popup #2850

merged 4 commits into from
Jun 25, 2025

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Jun 15, 2025

The dashboard attempts to fetch the latest version info at startup and can gracefully timeout without errors.
Add new setting to show popup, always hide it or hide it while a specific version is latest.
The popup does expand vertically and horizontally to accomodate the changelog message.

Screenshot 2025-06-15 at 11 13 58 pm

Copy link
Collaborator

@Meister1593 Meister1593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ui needs link to release page

Also might need a reminder (colored note?) to either download it from that release page, or use launcher to update alvr

@Meister1593
Copy link
Collaborator

Instead of ALVR v20.13.0 available it might be better also to move it to main text, and make top note say New ALVR version available

So it will be
New ALVR version available
ALVR v20.13.0
## Changes...

@zmerp
Copy link
Member Author

zmerp commented Jun 16, 2025

@Meister1593 How's this? It seems that automatic width breaks when using horizontal_wrapped but i think it's fine anyway.

Screenshot 2025-06-16 at 8 45 24 pm

@zmerp
Copy link
Member Author

zmerp commented Jun 16, 2025

Alternatively the text could be:

ALVR v20.13.0

You can download this version using the launcher

## Changes...

https://github.com/alvr-org/ALVR/releases

This puts emphasis on preferring the launcher

@Meister1593
Copy link
Collaborator

Alternatively the text could be:

ALVR v20.13.0

You can download this version using the launcher

## Changes...

https://github.com/alvr-org/ALVR/releases

This puts emphasis on preferring the launcher

Looks pretty good overall, just add note like Releases page - https://github.com/alvr-org/ALVR/releases

@Meister1593
Copy link
Collaborator

Might be a good idea also to add a note to launcher (where to download it), but i think it's fine for now

@zmerp
Copy link
Member Author

zmerp commented Jun 16, 2025

I added a button to open the launcher, if it's in the directory tree. If it's not it will open the releases page.
Should the button be small and inline?

Screenshot 2025-06-16 at 10 12 33 pm

@Meister1593
Copy link
Collaborator

Yeah, make it inline, though add some spacing between changes & top part (so that ui doesn't feel a bit compacted)

@zmerp
Copy link
Member Author

zmerp commented Jun 16, 2025

I customised the padding for the button to make it look better

Screenshot 2025-06-16 at 10 42 42 pm

@zmerp zmerp dismissed Meister1593’s stale review June 25, 2025 08:30

Discussion was resolved

@zmerp zmerp merged commit dc79dce into master Jun 25, 2025
9 checks passed
@zmerp zmerp deleted the update-popup branch June 25, 2025 08:30
zmerp added a commit that referenced this pull request Jun 27, 2025
* feat(dashboard): ✨ Add new version popup

* Add button to open launcher; follow up comments

* Address latest comments; move popup code to separate file

* Address review comments
@zmerp zmerp mentioned this pull request Jun 28, 2025
zmerp added a commit that referenced this pull request Jun 30, 2025
* feat(dashboard): ✨ Add new version popup

* Add button to open launcher; follow up comments

* Address latest comments; move popup code to separate file

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants