-
-
Notifications
You must be signed in to change notification settings - Fork 561
feat(dashboard): ✨ Add new version popup #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ui needs link to release page
Also might need a reminder (colored note?) to either download it from that release page, or use launcher to update alvr
Instead of So it will be |
@Meister1593 How's this? It seems that automatic width breaks when using horizontal_wrapped but i think it's fine anyway. ![]() |
Alternatively the text could be:
This puts emphasis on preferring the launcher |
Looks pretty good overall, just add note like |
Might be a good idea also to add a note to launcher (where to download it), but i think it's fine for now |
Yeah, make it inline, though add some spacing between changes & top part (so that ui doesn't feel a bit compacted) |
* feat(dashboard): ✨ Add new version popup * Add button to open launcher; follow up comments * Address latest comments; move popup code to separate file * Address review comments
* feat(dashboard): ✨ Add new version popup * Add button to open launcher; follow up comments * Address latest comments; move popup code to separate file * Address review comments
The dashboard attempts to fetch the latest version info at startup and can gracefully timeout without errors.
Add new setting to show popup, always hide it or hide it while a specific version is latest.
The popup does expand vertically and horizontally to accomodate the changelog message.