Add support for rendering string types to support amaranth enums #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Jun 20, 2025
|
It looks like you've introduced a few type errors:
Do you want to try your hand at investigating why these happen, or should I just fix them? |
whitequark
added a commit
that referenced
this pull request
Jun 20, 2025
|
Sorry was walking the dog and did not see this, didn't realize typescript would actually run without the types being right |
|
What linter do you use if I end up finding time to dig into #5 |
|
I just use VS Code. |
whitequark
added a commit
that referenced
this pull request
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4 Part 2/2
For Enums I monkey patched in a new renderer to d3-wave based on the RowRendererEnum. Obviously this is not exactly ideal (and its also my first time writing js/ts), so if you want to reject this part I can split this PR into two.
Closes #2