-
Notifications
You must be signed in to change notification settings - Fork 4
Update Android sample to Android 15 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
207b85f
to
9a7c48f
Compare
|
||
## 📱 Preview | ||
|
||
<img src="docs/screenshot.png" alt="App Screenshot" width="300" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may have a better naming for the png to illustrate the purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is the screen shot for the app
val connectInstanceId = configRepo.getConnectInstanceId() | ||
val contactFlowId = configRepo.getContactFlowId() | ||
val startWebrtcEndpoint = configRepo.getStartWebrtcEndpoint() | ||
val createParticipantConnectionEndpoint = configRepo.getCreateParticipantConnectionEndpoint() | ||
val sendMessageEndpoint = configRepo.getSendMessageEndpoint() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this addition an feature improvement(if so, add to PR description)? or part of Android 15 update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a debugging development thing that allows to load config in local property file, for easy setup and configure the config on the fly
@@ -0,0 +1,83 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature addition could be added to commit message or PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
@@ -10,6 +10,7 @@ | |||
<uses-permission android:name="android.permission.READ_PHONE_STATE" /> | |||
<uses-permission android:name="android.permission.CALL_PHONE" /> | |||
<uses-permission android:name="android.permission.FOREGROUND_SERVICE"/> | |||
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new permission needed for Android 15? If yes, we should also update Chime SDK Android readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added in SDK already, we want to have the parity on this sample
@@ -0,0 +1,70 @@ | |||
package com.amazonaws.services.connect.inappcalling.sample.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that we should also add to Chime SDK? or at least as a demo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already did
@@ -0,0 +1,58 @@ | |||
package com.amazonaws.services.connect.inappcalling.sample.data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the license header
@@ -0,0 +1,70 @@ | |||
package com.amazonaws.services.connect.inappcalling.sample.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing license header
@@ -0,0 +1,83 @@ | |||
package com.amazonaws.services.connect.inappcalling.sample.ui.utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing license header
I strongly suggest to have separate commits for different changes, like adding the config. |
This is a nit. |
Issue #:
N/A
Example:
Android
Description:
Testing:
QA tested.
Checklist:
If it's CPP web calling example change:
If it's iOS in-app calling example change:
If it's Android in-app calling example change:
If it's bankend api example change, have you verified both iOS/Android in-app calling examples are compatible with this change?