Skip to content

Update Android sample to Android 15 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Update Android sample to Android 15 #13

merged 1 commit into from
Jul 22, 2025

Conversation

linsang21
Copy link
Contributor

@linsang21 linsang21 commented Jun 18, 2025

Issue #:
N/A

Example:
Android

Description:

  • Update the app to compile and target to Android 15
  • Use latest Chime SDK
  • Support configure endpoints from local property and on the fly

Testing:
QA tested.

Checklist:

If it's CPP web calling example change:

  1. Have you verified the change works in all supporting broswers?
  2. Is integration tests chnage needed? If yes, please share the link for the change.

If it's iOS in-app calling example change:

  1. Have you verified the change works in all supporting iOS vesions?
  2. Is integration tests change needed? If yes, please share the link for the change.

If it's Android in-app calling example change:

  1. Have you verified the change works in all supporting Android vesions?
  2. Is integration tests change needed? If yes, please share the link for the change.

If it's bankend api example change, have you verified both iOS/Android in-app calling examples are compatible with this change?

@linsang21 linsang21 force-pushed the update-sdk branch 4 times, most recently from 207b85f to 9a7c48f Compare June 19, 2025 18:50

## 📱 Preview

<img src="docs/screenshot.png" alt="App Screenshot" width="300" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may have a better naming for the png to illustrate the purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the screen shot for the app

Comment on lines +54 to +58
val connectInstanceId = configRepo.getConnectInstanceId()
val contactFlowId = configRepo.getContactFlowId()
val startWebrtcEndpoint = configRepo.getStartWebrtcEndpoint()
val createParticipantConnectionEndpoint = configRepo.getCreateParticipantConnectionEndpoint()
val sendMessageEndpoint = configRepo.getSendMessageEndpoint()
Copy link

@ziyiz-amzn ziyiz-amzn Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addition an feature improvement(if so, add to PR description)? or part of Android 15 update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a debugging development thing that allows to load config in local property file, for easy setup and configure the config on the fly

@@ -0,0 +1,83 @@
<?xml version="1.0" encoding="utf-8"?>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature addition could be added to commit message or PR description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -10,6 +10,7 @@
<uses-permission android:name="android.permission.READ_PHONE_STATE" />
<uses-permission android:name="android.permission.CALL_PHONE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new permission needed for Android 15? If yes, we should also update Chime SDK Android readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added in SDK already, we want to have the parity on this sample

@@ -0,0 +1,70 @@
package com.amazonaws.services.connect.inappcalling.sample.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that we should also add to Chime SDK? or at least as a demo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already did

@@ -0,0 +1,58 @@
package com.amazonaws.services.connect.inappcalling.sample.data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the license header

@@ -0,0 +1,70 @@
package com.amazonaws.services.connect.inappcalling.sample.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header

@@ -0,0 +1,83 @@
package com.amazonaws.services.connect.inappcalling.sample.ui.utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header

@georgezy-amzn
Copy link
Contributor

I strongly suggest to have separate commits for different changes, like adding the config.

@georgezy-amzn
Copy link
Contributor

I strongly suggest to have separate commits for different changes, like adding the config.

This is a nit.

@linsang21 linsang21 merged commit 98b9f97 into main Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants