Add expression group transcription to conformance DSL #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 138 138
Lines 35637 35637
Branches 35637 35637
=======================================
Hits 28110 28110
Misses 5410 5410
Partials 2117 2117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jobarr-amzn
approved these changes
Jun 11, 2025
tests/conformance_dsl/fragment.rs
Outdated
| .as_sexp() | ||
| .unwrap() // Verified above | ||
| .iter() | ||
| .skip(1); |
There was a problem hiding this comment.
This is skipping the first element, the #$::, right? If I am correct could you add a comment for posterity, and if I am wrong could you add a comment telling me what is the deal here?
There was a problem hiding this comment.
Yep that's exactly why. I'll add a comment, good call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #935
Description of changes:
Prior to this PR using an expression group within a
toplevelclause would fail. The existing code captured the::for a normal expression group, but due to the DSL's transcription syntax we need to capture#$::and construct an expression group through the eexp writer.This PR captures the
#$::notation, and constructs the expression group via the writer.Two tests were also added to the conformance DSL unit tests to ensure the behavior as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.