Skip to content

New plugin: sysctl #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 18, 2025
Merged

New plugin: sysctl #33

merged 10 commits into from
Aug 18, 2025
+456 −0

Conversation

alexandraBara
Copy link
Collaborator

Gathering sysctl settings:

vm.swappiness
vm.numa_balancing
vm.oom_kill_allocating_task
vm.compaction_proactiveness
vm.compact_unevictable_allowed
vm.extfrag_threshold
vm.zone_reclaim_mode
vm.dirty_background_ratio
vm.dirty_ratio
vm.dirty_writeback_centisecs
kernel.numa_balancing

@alexandraBara alexandraBara requested a review from sternma August 13, 2025 14:06
landrews-amd
landrews-amd requested changes Aug 15, 2025
View reviewed changes
nodescraper/plugins/inband/sysctl/sysctl_collector.py Outdated
if values:
sysctl_data = SysctlDataModel(**values)
self._log_event(
category="SYSCTL_READ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category should just be 'OS'

nodescraper/plugins/inband/sysctl/sysctl_analyzer.py Outdated
self, data: SysctlDataModel, args: Optional[SysctlAnalyzerArgs] = None
) -> TaskResult:
"""Analyze the Sysctl data against expected Sysctl values."""
self.result = self.result
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant

nodescraper/plugins/inband/sysctl/sysctl_analyzer.py Outdated
Comment on lines 47 to 48
self.result.status = ExecutionStatus.OK
self.result.message = "All expected sysctl parameters match."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be clearer to set these in the else at the end on line 75

@alexandraBara alexandraBara merged commit d44d952 into development Aug 18, 2025
5 checks passed
@alexandraBara alexandraBara deleted the alex_sys_settings branch August 18, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landrews-amd landrews-amd landrews-amd approved these changes

@sternma sternma Awaiting requested review from sternma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandraBara @landrews-amd