Added cron job and workflow dispatch triggers to CI workflow #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Jul 31, 2024
| pull_request: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: 0 6 * * * |
There was a problem hiding this comment.
Because this was last tested 7 months ago and it is set up to build against the latest version of Redis, which is moving forwards over time, so this will alert you if an incompatibility arises going forward. Moreover, since there is no composer.lock, all the libraries can change, as is the case presently, since CI is failing with Psalm errors which were unknown until someone tried to create a PR. For either, but especially both of these reasons, we should have a daily cron. It's not like it costs you anything, so I don't see a downside.
| - pull_request | ||
| push: | ||
| pull_request: | ||
| workflow_dispatch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow dispatch trigger allows manually running the workflow from the web UI.