library/spi_engine: Extend SDO support for the SPI Engine #1808
+1,633
−406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend SDO support to 8 (symmetrical with SDI support); * Update SDI to use asymmetrical FIFO; * Insert symmetrical FIFO for the SDO; * Insert SPI lane mask configuration instruction to reg 2'b11; * Insert offload active interface for interconnect and execution; * Remove register 8'h3b from spi engine regmap. Prefetching on offload work iff all lanes are active. Signed-off-by: Carlos Souza <[email protected]>
* Update documentation to include the changes done for supporting more than one SDO lane. * Update the register map. Signed-off-by: Carlos Souza <[email protected]>
Removed dead code from Util AXIS FIFO ASYM library. Signed-off-by: Carlos Souza <[email protected]>
LBFFilho
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Overall this seems headed in a nice direction, and thanks for also doing a lot of small fixes and improvements to the existing code along the way.
About the version: is this going to be a minor version or a major version bump? I understand that the removed register was not used anywhere (it was broken even), but technically we're breaking anything that relied on it. Also changing the behavior of the SDI & SDO FIFOs.
Also, please check timing on ad4052/de10nano just to be sure if it's all good.
| @@ -69,7 +70,7 @@ module spi_engine_execution #( | |||
|
|
|||
| input echo_sclk, | |||
| output reg sclk, | |||
| output reg sdo, | |||
| output reg [NUM_OF_SDI-1:0] sdo, | |||
There was a problem hiding this comment.
Since now this applies to both sdi and sdo, please rename it to reflect the change.
library/spi_engine/spi_engine_execution/spi_engine_execution_shiftreg.v
Outdated
Show resolved
Hide resolved
library/spi_engine/spi_engine_execution/spi_engine_execution_shiftreg.v
Outdated
Show resolved
Hide resolved
library/spi_engine/spi_engine_execution/spi_engine_execution_shiftreg_data_assemble.v
Outdated
Show resolved
Hide resolved
LBFFilho
reviewed
Jul 2, 2025
LBFFilho
requested changes
Jul 2, 2025
LBFFilho
reviewed
Jul 2, 2025
LBFFilho
reviewed
Jul 2, 2025
caosjr
force-pushed
the
sdo_extension_spi_engine
branch
3 times, most recently
from
8a2552e to
15eaefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please replace this comment with summary, motivation and context of the changes.
List any dependencies required for this change.
You can check the checkboxes below by inserting a 'x' between square brackets
(without any other characters or spaces) or just check them after publishing the PR.
If there is a breaking change, specify dependent PRs in description and
try to push all related PRs at the same time.
PR Type
PR Checklist