Skip to content

drivers/misc/mathworks: Use wrapper mathods for devm #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

drivers/misc/mathworks: Use wrapper mathods for devm #2875

wants to merge 2 commits into from
+91 −18

Conversation

gastmaier
Copy link
Contributor

@gastmaier gastmaier commented Aug 4, 2025 •
edited
Loading

PR Description

To solve

cast from 'void (*)(struct device *)' to 'devm_action_fn' (aka 'void (*)(void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 48 | status = devm_add_action_helper(thisIpcore->dev, (devm_action_fn)put_device, &thisIpcore->i2c->dev); |

on strict compile

Not sure the upstream for this driver.

Note: changed base to test #2877

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@gastmaier
drivers/misc/mathworks: Use wrapper mathods for devm
c6fc759 
To solve
  cast from 'void (*)(struct device *)' to 'devm_action_fn' (aka 'void
  (*)(void *)') converts to incompatible function type
  [-Werror,-Wcast-function-type-strict]
on strict compile

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier gastmaier changed the base branch from main to ci/changes August 4, 2025 15:56
@gastmaier
drivers/misc/mathworks: Extend ifdef CONFIG_I2C
d2196a2 
To avoid unused warnings.

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier gastmaier closed this Aug 5, 2025
@gastmaier gastmaier reopened this Aug 5, 2025
Base automatically changed from ci/changes to main August 5, 2025 12:01
@gastmaier gastmaier marked this pull request as draft August 6, 2025 08:01
@gastmaier gastmaier changed the base branch from main to ci/changes August 6, 2025 08:01
@gastmaier gastmaier force-pushed the staging/mw-fix branch 3 times, most recently from ba04519 to c8f46b8 Compare August 6, 2025 09:04
@gastmaier gastmaier force-pushed the staging/mw-fix branch 3 times, most recently from 3ca0cc8 to d2196a2 Compare August 6, 2025 11:58
Base automatically changed from ci/changes to main August 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa Awaiting requested review from nunojsa nunojsa is a code owner

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gastmaier