ADSP-SC598 upstream driver changes v2 #2908

artursartamonovsadi · 2025-08-25T15:34:44Z

Minimal patch set to boot into ADSP-SC598-SOM with initramfs to UART Linux shell.
Based on v1 sent to kernel mailinglist. Tested with ADSP-SC598-SOM RevC

PR Type

Bug fix (a change that fixes an issue)
[x ] New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

[x ] I have conducted a self-review of my own code changes
[x ] I have tested the changes on the relevant hardware
[x ] I have updated the documentation outside this repo accordingly (if there is the case)

Add ADSP-SC598 platform. Co-developed-by: Utsav Agarwal <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Support custom GPIO pin configuration for non-GPIO functions. Co-developed-by: Utsav Agarwal <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Adding support for ADI ADSP reset controller. This driver allows trigger a software reset. Co-developed-by: Utsav Agarwal <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Bindigs for ADI ADSP-SC5xx reset controller Co-developed-by: Utsav Agarwal <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

add SoC ADSP-SC5xx Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Implements clock tree, no dynamic pll rate change. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC5xx clock driver Co-developed-by: Arturs Artamonovs <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC5xx clock bindings. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC5xx GPIO driver. - Support all GPIO ports - Each gpio support seperate PINT interrupt controller Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC5xx GPIO driver bindings. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC5xx pinctrler: - Support switching GPIO pin functions. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add PINCTRL driver bindings. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add support for I2C on SC5xx Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add I2C driver bindings. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Adding UART driver,supports all ADSP-SC5xx SoC family - Support FIFO mode - Support earlyprintk - Support Enable Divide By One support, for higher clock resolutions. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add serial driver bindings. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADI SC598-EZKIT device tree. Support UART console as output. Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC598 defconfig Co-developed-by: Utsav Agarwal <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Co-developed-by: Greg Malysa <[email protected]> Signed-off-by: Greg Malysa <[email protected]> Co-developed-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Nathan Barrett-Morrison <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

Add ADSP-SC598 maitaniners Signed-off-by: Arturs Artamonovs <[email protected]>

pamolloy · 2025-08-26T06:02:54Z

Thanks so much for posting this! @UtsavAgarwalADI and I were chatting about the sign off section for an earlier set of patches. It is probably easier to just discuss it in person, but also take a look at https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by. The two examples at the end of the section are especially helpful.

pamolloy · 2025-08-26T06:08:23Z

It would be good to link to the original mailing list review in the description:

https://lore.kernel.org/lkml/[email protected]/

arch/arm64/Kconfig.platforms

pamolloy · 2025-08-26T08:43:10Z

arch/arm64/Kconfig.platforms

+	select COUNTER
+	help
+	  This enables support for Analog Devices Incorporated's
+	  Family of ARM64 DSP processors


Then maybe mention here ADSP-SC596 and ADSP-SC598 explicitly

pamolloy · 2025-08-26T08:45:10Z

drivers/clk/adi/clk-adi-pll.c

+MODULE_DESCRIPTION("Analog Devices CLock PLL driver");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Greg Malysa <[email protected]>");
+


Suggested change

pamolloy · 2025-08-26T08:46:45Z

drivers/clk/adi/clk.h

+	unsigned int			id;
+	enum adi_clk_branch_type	branch_type;
+	const char			*name;
+	const char			*const *parent_names; //should be const?


This should be addressed or removed

pamolloy · 2025-08-26T08:46:47Z

drivers/clk/adi/clk.h

+	const char			*const *parent_names; //should be const?
+	u8				num_parents;
+	unsigned long			flags;
+	unsigned long			offset; //void ** iomem offset?!


This should be addressed or removed

pamolloy · 2025-08-26T09:06:34Z

drivers/tty/serial/Kconfig

@@ -771,7 +788,7 @@ config SERIAL_CPM
 	depends on CPM2 || CPM1
 	select SERIAL_CORE
 	help
-	  This driver supports the SCC and SMC serial ports on Motorola 
+	  This driver supports the SCC and SMC serial ports on Motorola


@nunojsa should this go in a different commit? Perhaps get submitted separately? The whitespace is still there on next.

Probably was fixed when did the checkpatch, will revert this

Yeps, it should go in a separate commit

@artursartamonovsadi you don't need to revert it, just move it into a new commit. Still a valuable contribution!

pamolloy · 2025-08-26T10:18:14Z

Documentation/devicetree/bindings/arm/analog/adi,sc5xx.yaml

+$id: http://devicetree.org/schemas/arm/analog/adi,sc5xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices SC59X 64-Bit ARM-based Processor Families


Suggested change

title: Analog Devices SC59X 64-Bit ARM-based Processor Families

title: Platforms based on Analog Devices SC59X 64-Bit SoCs

But the filename is sc5xx.yaml. So maybe sc59x.yaml or as much as I hate it, sc59x_64.yaml since aarch64 isn't in a separate directory here.

Signed-off-by: Arturs Artamonovs <[email protected]>

gastmaier · 2025-08-28T09:34:04Z

The ci runs on individual commits, in the context of as a series to be submitted.
Fixing the checkpatch warnings as a commit in the head won't fix the run, instead you do need to rewrite history, like a v2 submission.

You can even keep the cover letter commit, if you want

artursartamonovsadi · 2025-08-28T09:57:50Z

Im also running the checkpatch locally to see whole picture.

artursartamonovsadi added 19 commits August 22, 2025 17:01

clock: Add driver for ADI ADSP-SC5xx clock

e219f29

Add ADSP-SC5xx clock driver Co-developed-by: Arturs Artamonovs <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]> Signed-off-by: Utsav Agarwal <[email protected]> Signed-off-by: Arturs Artamonovs <[email protected]>

MAINTAINERS: add adi sc5xx maintainers

55b4443

Add ADSP-SC598 maitaniners Signed-off-by: Arturs Artamonovs <[email protected]>

artursartamonovsadi requested review from pamolloy, vasbimpikasadi, UtsavAgarwalADI and CalebEthridgeADI August 25, 2025 15:34

artursartamonovsadi requested review from nunojsa, mhennerich, dbogdan, btogorean, chegbeli, buha and amiclaus as code owners August 25, 2025 15:34

artursartamonovsadi requested review from danmois, CiprianRegus and machschmitt as code owners August 25, 2025 15:34

pamolloy requested a review from gastmaier August 26, 2025 05:59

pamolloy assigned artursartamonovsadi Aug 26, 2025

pamolloy reviewed Aug 26, 2025

View reviewed changes

arch/arm64/Kconfig.platforms Show resolved Hide resolved

pamolloy reviewed Aug 26, 2025

View reviewed changes

artursartamonovsadi removed request for gastmaier, buha, CiprianRegus, amiclaus, btogorean, chegbeli, danmois, rbolboac and machschmitt August 26, 2025 08:56

pamolloy reviewed Aug 26, 2025

View reviewed changes

artursartamonovsadi added 5 commits August 26, 2025 16:46

arm64: dts: adi: enabled disabled clocks

a4a4dd4

Signed-off-by: Arturs Artamonovs <[email protected]>

tty: revert extra whitespace that's not related to SC5XX

4f7b0ee

Signed-off-by: Arturs Artamonovs <[email protected]>

reset: adi: remove trailing whitespace

03d018c

Signed-off-by: Arturs Artamonovs <[email protected]>

Replace all Greg Malysa old emails to new one

ea97238

Signed-off-by: Arturs Artamonovs <[email protected]>

adi: checkpatch strict fixes

517229d

Signed-off-by: Arturs Artamonovs <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ADSP-SC598 upstream driver changes v2 #2908

ADSP-SC598 upstream driver changes v2 #2908

Uh oh!

artursartamonovsadi commented Aug 25, 2025

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

artursartamonovsadi Aug 26, 2025

Uh oh!

nunojsa Aug 27, 2025

Uh oh!

pamolloy Aug 27, 2025

Uh oh!

pamolloy Aug 26, 2025

Uh oh!

gastmaier commented Aug 28, 2025 •

edited

Loading

Uh oh!

artursartamonovsadi commented Aug 28, 2025

Uh oh!

Uh oh!

	title: Analog Devices SC59X 64-Bit ARM-based Processor Families
	title: Platforms based on Analog Devices SC59X 64-Bit SoCs

ADSP-SC598 upstream driver changes v2 #2908

Are you sure you want to change the base?

ADSP-SC598 upstream driver changes v2 #2908

Uh oh!

Conversation

artursartamonovsadi commented Aug 25, 2025

PR Type

PR Checklist

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

pamolloy commented Aug 26, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gastmaier commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artursartamonovsadi commented Aug 28, 2025

Uh oh!

Uh oh!

gastmaier commented Aug 28, 2025 •

edited

Loading