Madura add orx #2923
Open
Madura add orx #2923
+3,444
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmois
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
CiprianRegus and
machschmitt
as code owners
danmois
force-pushed
the
madura_add_orx
branch
from
ca70188 to
31ab3de
Compare
|
V2
|
nunojsa
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Hi,
So the first patch needs splitting... Do not mix driver code with devicetree and the config change should also be in a separate patch. Then, the second patch seems to be relevant for the whole "Add ORx support" so to me it would only be one patch. So to sum up, I think this should be:
- "iio: adc: adrv902x: Make JESD ops static"
- Add ORx support in DT;
- Add defconfig change;
- Add ORx support in the driver:
Make all JESD ops static. Signed-off-by: George Mois <[email protected]>
danmois
force-pushed
the
madura_add_orx
branch
from
31ab3de to
4ea4710
Compare
|
V3
|
nunojsa
reviewed
Aug 29, 2025
| * | ||
| * Copyright (C) 2020-2025 Analog Devices Inc. | ||
| */ | ||
| #include "vcu118_adrv9025.dts" |
There was a problem hiding this comment.
Ah I failed to realize this... Being nitpicky, the microblaze DT should be in a separate patch. Anyways, just a hint for the future. No need to change it if there isn't a stronger reason for you to re-spin.
| @@ -0,0 +1,3030 @@ | |||
| { | |||
| "dataInterface": { | |||
There was a problem hiding this comment.
The firmware should be in a different patch. Different change and different directory :)
| @@ -74,7 +74,7 @@ CONFIG_NET_DSA=y | |||
| CONFIG_PCI=y | |||
| CONFIG_DEVTMPFS=y | |||
| CONFIG_DEVTMPFS_MOUNT=y | |||
| CONFIG_EXTRA_FIRMWARE="ad9467_intbypass_ad9517.stp ad9517.stp Mykonos_M3.bin TaliseStream.bin TaliseTDDArmFirmware.bin TaliseTxArmFirmware.bin TaliseRxArmFirmware.bin ADRV9025_DPDCORE_FW.bin ADRV9025_FW.bin ADRV9025_RxGainTable.csv ADRV9025_TxAttenTable.csv stream_image_6E3E00EFB74FE7D465FA88A171B81B8F.bin ActiveUseCase.profile ActiveUtilInit.profile" | |||
| CONFIG_EXTRA_FIRMWARE="ad9467_intbypass_ad9517.stp ad9517.stp Mykonos_M3.bin TaliseStream.bin TaliseTDDArmFirmware.bin TaliseTxArmFirmware.bin TaliseRxArmFirmware.bin ADRV9025_DPDCORE_FW.bin ADRV9025_FW.bin ADRV9025_RxGainTable.csv ADRV9025_TxAttenTable.csv stream_image_6E3E00EFB74FE7D465FA88A171B81B8F.bin ActiveUseCase.profile ActiveUtilInit.profile ActiveUseCase_NLS.profile" | |||
There was a problem hiding this comment.
It would also be a different patch
| case CHAN_RX1: | ||
| case CHAN_RX2: | ||
| case CHAN_RX3: | ||
| case CHAN_RX4: |
There was a problem hiding this comment.
case CHAN_RX1 ... CHAN_RX4? If it's sequential, it should be fine
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
| @@ -1724,8 +1821,18 @@ static int adrv9025_clk_register(struct adrv9025_rf_phy *phy, const char *name, | |||
|
|
|||
| switch (source) { | |||
| case RX_SAMPL_CLK: | |||
| adrv9025_RxLinkSamplingRateFind(phy->madDevice, &phy->deviceInitStruct, | |||
| ADI_ADRV9025_FRAMER_0, | |||
| &rate); | |||
drivers/iio/adc/adrv902x/adrv9025.c
Outdated
| case OBS_SAMPL_CLK: | ||
| adrv9025_RxLinkSamplingRateFind(phy->madDevice, &phy->deviceInitStruct, | ||
| ADI_ADRV9025_FRAMER_1, | ||
| &rate); |
There was a problem hiding this comment.
same question, do we need to check return values?
Add ORx support in DT for ZCU102. Signed-off-by: George Mois <[email protected]>
Add ORx support in DT for VCU118. Signed-off-by: George Mois <[email protected]>
Add non-link sharing profile for ADRV9025. Signed-off-by: George Mois <[email protected]>
Update defconfig for ZynqMP. Signed-off-by: George Mois <[email protected]>
Update defconfig for MicroBlaze. Signed-off-by: George Mois <[email protected]>
Add ORx support in the ADRV902X driver. Signed-off-by: George Mois <[email protected]>
danmois
force-pushed
the
madura_add_orx
branch
from
4ea4710 to
ccc2d9a
Compare
|
V4
|
nunojsa
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add observation inputs for ADRV902X.
PR Type
PR Checklist