on a very small (or large) version, do not index #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjbs, could you please review and fix the conflicts? |
rjbs
force-pushed
the
very-small-version
branch
from
f2c3ee5 to
4194459
Compare
rjbs
force-pushed
the
very-small-version
branch
from
4194459 to
f492747
Compare
rjbs
force-pushed
the
very-small-version
branch
3 times, most recently
from
51027c5 to
0774909
Compare
Really, this should become a useful user message, but it's painfully difficult to get that error up through the call stack. This code needs (in my opinion) to be rearchitected to make this sort of thing simple. In the meantime, the code now detects this case specifically, so we can do something about it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really, this should become a useful user message, but it's painfully difficult to get that error up through the call stack. This code needs (in my opinion) to be rearchitected to make this sort of thing simple.
In the meantime, the code now detects this case specifically, so we can do something about it later.
Meant to help with #192, but won't help enough until we can get the message passed upward.