Check for a divide by zero in the step calculation #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great library! I'm still evaluating if it'll work for my needs but I managed to find one SEGFAULT along the way.
with this code, if
l
is below0.2
(0.1995
or so in my case) then the number of iterations will be 0 and step will benan
, which breaks things down the chain and ends up with an attempt to read an out of bounds value from the lightmap.