-
Notifications
You must be signed in to change notification settings - Fork 51
AAP-48412 Unified RBAC display, sync with resource server #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1cbe771
to
fd7d371
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1363 +/- ##
==========================================
- Coverage 94.15% 94.13% -0.02%
==========================================
Files 335 335
Lines 19533 19537 +4
==========================================
Hits 18391 18391
- Misses 1142 1146 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
New results from E2E tests give 8 failures.
Honestly, this looks related to ansible/django-ansible-base#765 from @PabloHiro and I will put up a new eda-server patch for this. |
Created #1366 to flesh that out. |
@AlanCoding is there a chance that the new version od DAB could require a new generation of the openapi spec? in that case we will need to upgrade the test suite too. |
Yep, #1367 shows the same 8 failures so 🟢 here, although there's more work generated from all this... |
Oh the tests probably failed because I rebased the DAB branch, making the git ref defunct. So this just needs a poetry update. |
No reverse sync in preload data script Add EDA prefix to project level roles Directly include RBAC service endpoints
d3391c1
to
ef563e4
Compare
771ed35
to
0f4c2b0
Compare
|
This is the supporting eda-server patch for the core backend change for ASTRAT-1464
See this doc for more background.
requires ansible/django-ansible-base#749
This adds endpoints and enables syncing logic to mirror EDA permissions in the resource server, so that a unified view of all the permissions to objects can be given. A recap of the general component changes, which are being applied to eda-server here:
The migration dependencies were done slightly different here, because the testing of the "Project Admin" role rename required migrating forward & backwards, and I had no intent of making the DAB migrations reversible. It seems to work fine as it is here.
Testing is mostly with aap-dev.
Requesting review from @ptoscano