-
-
Notifications
You must be signed in to change notification settings - Fork 33
Update OpenSSL to 3.5.0 in manylinux #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
0371ac8
to
ab8c4be
Compare
The s390x issue was fixed with the suggestion from openssl/openssl#27323 -- should have mentioned in the commit message. If it will work, I can amend. |
|
||
pushd openssl-${OPENSSL_VERSION} | ||
pushd ${OPENSSL_VERSION} | ||
BUILD_FLAGS="$OPENSSL_BUILD_FLAGS" | ||
if [[ "$1" =~ '^manylinux1_.*$' ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: we should drop this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to move it into separate issue or should I create separate PR with this right away? I think also the perl installation can be dropped now, when we install perl from RPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's a number of compatibility fallbacks that I haven't removed while dropping older manylinux base images. Feel free to look into this whenever. But it doesn't block anything, so there's no rush, really. I just posted the note for myself.
This also changes the way how the libssh finds the OpenSSL installation to use the `OPENSSL_ROOT_DIR` variable. Based partially on the changes in ansible#719, partially on current version of https://github.com/pyca/infra/tree/main/cryptography-linux The s390x issue was fixed with the suggestion from openssl/openssl#27323 The new openssl build takes longer (especially on ppc64le) so bumping the timeout to 50 minutes. Signed-off-by: Jakub Jelen <[email protected]>
|
SUMMARY
This also changes the way how the libssh finds the OpenSSL installation to use the
OPENSSL_ROOT_DIR
variable.Based partially on the changes in #719 and from the https://github.com/pyca/infra/tree/main/cryptography-linux
ISSUE TYPE