support parse create function #19
Conversation
donga-gao
commented
Sep 2, 2024
donga-gao
commented
- support parse create function
- Issue add sql_segment
There was a problem hiding this comment.
Please split this into two separate commits. One with the issue refactor, one with the changes to create_function.
Why do you want to add the "sql_segment" to the Issue. It seems that is is just the code under span. If we want to add these sql_segments to the Issue. Perhaps we could add a lifetime to issue, and have the sql_segments an slices, so we do not need to allocate new strings.
src/create.rs
Outdated
| if parser.options.dialect.is_maria() && direction.is_none() { | ||
| parser.expected_error("'IN', 'OUT' or 'INOUT'"); | ||
| } | ||
| // [IN|OUT|INOUT] is not required in mysql |
There was a problem hiding this comment.
If this is indeed the case, please remove the code instead of commenting it out.
src/statement.rs
Outdated
| @@ -277,6 +277,7 @@ pub enum Statement<'a> { | |||
| TruncateTable(TruncateTable<'a>), | |||
| RenameTable(RenameTable<'a>), | |||
| WithQuery(WithQuery<'a>), | |||
| RETURN(Return<'a>), | |||
There was a problem hiding this comment.
The enum variant should be called Return not RETURN
src/create.rs
Outdated
| @@ -638,78 +602,12 @@ fn parse_create_function<'a>( | |||
| } | |||
| } | |||
|
|
|||
| let mut characteristics = Vec::new(); | |||
There was a problem hiding this comment.
Where did the characteristic go?
There was a problem hiding this comment.
function characteristics is not suitable for parse function body. function body is more like block statement. So I add Return sql in statement for parse function body as a block statement.
