WIP: Remove tableId constructor for load balancers #5426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the single tableId constructor for SimpleLoadBalancer as it is no longer needed with the addition of the tablesToBalance map to the balancerParams.
ctubbsii
reviewed
Mar 25, 2025
Comment on lines
-69
to
-77
| // if tableToBalance is set, then only balance the given table | ||
| TableId tableToBalance = null; | ||
|
|
||
| public SimpleLoadBalancer() {} | ||
|
|
||
| public SimpleLoadBalancer(TableId table) { | ||
| tableToBalance = table; | ||
| } | ||
|
|
There was a problem hiding this comment.
Just adding context here: this constructor wasn't added to comply with the TabletBalancer SPI, but to make this implementation supportable by the delegating per-table balancer named TableLoadBalancer.
The whole reason TableLoadBalancer exists is to delegate to other balancers on a per-table basis. If that is no longer needed, because per-table delegation is now built-in at a higher level, then the whole TableLoadBalancer can be deleted... it is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the single tableId constructor for SimpleLoadBalancer as it is no longer needed with the addition of the tablesToBalance map to the balancerParams.
This PR addresses the changes from #5363 but applied to
main.Will also need to remove the single table constructors that are marked as deprecated in #5425