adds early return for all sys tables in ClientTabletCacheImpl.request… #5487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomGarguilo
approved these changes
Apr 18, 2025
ddanielr
approved these changes
Apr 19, 2025
ctubbsii
reviewed
Apr 22, 2025
| @@ -632,7 +632,7 @@ private void requestTabletHosting(ClientContext context, | |||
| } | |||
|
|
|||
| // System tables should always be hosted | |||
| if (AccumuloTable.ROOT.tableId() == tableId || AccumuloTable.METADATA.tableId() == tableId) { | |||
| if (AccumuloTable.allTableIds().contains(tableId)) { | |||
There was a problem hiding this comment.
I think the class AccumuloTable is really a misnomer. It's really TablesInTheAccumuloNamespace, and would probably be more intuitive if named AccumuloNamespace, with methods like .containsTable(tableId), or .tables().contains(TableId). There are several places in the code that have this pattern of checking that a tableId is contained in this set that would benefit from such a change. A similar comment was made on #5451
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TabletHosting
From discussion #5474 (comment)