Skip to content

Implement single thread for bulk operations #5592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement single thread for bulk operations #5592

wants to merge 1 commit into from

Conversation

arsenalzp
Copy link
Contributor

This PR introduces single thread for bulk operations. PR is related to issue #5524

@dlmarion dlmarion requested a review from keith-turner May 30, 2025 12:18
@dlmarion dlmarion added this to the 4.0.0 milestone May 30, 2025
@arsenalzp arsenalzp requested a review from keith-turner June 5, 2025 10:13
@arsenalzp
Copy link
Contributor Author

arsenalzp commented Jun 13, 2025 •
edited
Loading

Hello,
I run mvn clean package however it failed with warnings and subsequent error:

[WARNING] COMPILATION WARNING : 
[INFO] -------------------------------------------------------------
[WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java:[80,81] possible 'this' escape before subclass is fully initialized
[WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:[49,35] non-transient instance field of a serializable class declared with a non-serializable type
[WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:[50,30] non-transient instance field of a serializable class declared with a non-serializable type
[WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooSession.java:[251,30] implicit cast from long to int in compound assignment is possibly lossy
[WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/logging/ConditionalLogger.java:[69,9] non-transient instance field of a serializable class declared with a non-serializable type
[INFO] 5 warnings

...

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project accumulo-core: Compilation failure
[ERROR] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java: warnings found and -Werror specified

I'm using the following java version

Apache Maven 3.9.6 (Red Hat 3.9.6-6)
Maven home: /usr/share/maven
Java version: 21.0.5, vendor: Red Hat, Inc., runtime: /usr/lib/jvm/java-21-openjdk-21.0.5.0.11-1.fc40.x86_64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.11.10-200.fc40.x86_64", arch: "amd64", family: "unix"

UPDATE:
Fixed by changing JAVA_HOME to use jdk 17

UPDATE:
Fixed the import sort

@arsenalzp
Copy link
Contributor Author

Hello colleagues,
What is remaining before merge intro main?

@arsenalzp
implement single thread for bulk operation
220ede9 
Signed-off-by: Oleksandr Krutko <[email protected]>

move Threads pool instance creation in Manager class

Signed-off-by: Oleksandr Krutko <[email protected]>

remove unused call, some variables were inlined

Signed-off-by: Oleksandr Krutko <[email protected]>

remove Threads pool shutdown call from VolumeManagerImpl.bulkRename() method

Signed-off-by: Oleksandr Krutko <[email protected]>

fix imports sorting

Signed-off-by: Oleksandr Krutko <[email protected]>

add maintenance of Future objects

Signed-off-by: Oleksandr Krutko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-turner keith-turner keith-turner left review comments

Assignees

@arsenalzp arsenalzp

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arsenalzp @keith-turner @dlmarion