Send error back from TabletManagementIterator on invalid metadata #5668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the TabletManagementIterator to invoke getPrevEndRow() on the constructed TabletMetadata object to catch a the raised IllegalStateException and return it to the Manager. The existing try/catch around computeTabletManagementActions would likely throw the IllegalStateException when tm.getExtent is called when trying to log an error, preventing the error from being retured to the Manager. There is an existing test case, TabletMetadataTest.testAbsentPrevRow, which demonstrates that an IllegalStateException is raised when TabletMetadata.convertRow is called on a set of keys that don't contain a prevEndRow. Closes apache#5658
There was a problem hiding this comment.
Would be really nice to add some tests to TabletManagementIteratorIT to cover a few cases and ensure that the tablets that are ok are returned and the ones that have illegal metadata are reported. Maybe something like the following?
Maybe something like the following
- ok tablet that needs split
- tablet w/ missing end row
- ok tablet
- tablet w/ invalid json in the file column
- ok tablet
- tablet w/ valid json w/ a range that does not overlap that tablet (not sure this will cause a failure)
- What other busted tablet metadata situations could we cover?
| } catch (Exception e) { | ||
| LOG.error("Error computing tablet management actions for extent: {}", tm.getExtent(), e); | ||
| // Validate that a minimum set of keys were seen to create a valid tablet | ||
| tm.getPrevEndRow(); |
There was a problem hiding this comment.
A few lines up there is a call to TabletMetadata.convertRow() that could possibly fail. If it does it would be nice to handle that propogating back an error and log keys.get(0).getRow() to point to the row of the busted tablet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the TabletManagementIterator to invoke getPrevEndRow() on the constructed TabletMetadata object to catch a the raised IllegalStateException and return it to the Manager. The existing try/catch around computeTabletManagementActions would likely throw the IllegalStateException when tm.getExtent is called when trying to log an error, preventing the error from being retured to the Manager.
There is an existing test case, TabletMetadataTest.testAbsentPrevRow, which demonstrates that an IllegalStateException is raised when TabletMetadata.convertRow is called on a set of keys that don't contain a prevEndRow.
Closes #5658